llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clangd Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/139382.diff 5 Files Affected: - (modified) clang-tools-extra/clangd/DumpAST.cpp (-1) - (modified) clang-tools-extra/clangd/unittests/SerializationTests.cpp (-1) - (modified) clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp (-1) - (modified) clang-tools-extra/modularize/Modularize.cpp (-2) - (modified) clang-tools-extra/modularize/PreprocessorTracker.cpp (-2) ``````````diff diff --git a/clang-tools-extra/clangd/DumpAST.cpp b/clang-tools-extra/clangd/DumpAST.cpp index 584bb1f088380..8f24477ecd3de 100644 --- a/clang-tools-extra/clangd/DumpAST.cpp +++ b/clang-tools-extra/clangd/DumpAST.cpp @@ -124,7 +124,6 @@ class DumpVisitor : public RecursiveASTVisitor<DumpVisitor> { return Result; } std::string getKind(const TypeLoc &TL) { - std::string Result; if (TL.getTypeLocClass() == TypeLoc::Qualified) return "Qualified"; return TL.getType()->getTypeClassName(); diff --git a/clang-tools-extra/clangd/unittests/SerializationTests.cpp b/clang-tools-extra/clangd/unittests/SerializationTests.cpp index 2a7a6c36d3d17..d18ae478c1653 100644 --- a/clang-tools-extra/clangd/unittests/SerializationTests.cpp +++ b/clang-tools-extra/clangd/unittests/SerializationTests.cpp @@ -433,7 +433,6 @@ TEST(SerializationTest, NoCrashOnBadStringTableSize) { std::string CorruptStri = (llvm::fromHex("ffffffff") + Stri->Data.drop_front(4)).str(); Stri->Data = CorruptStri; - std::string FileDigest = llvm::fromHex("EED8F5EAF25C453C"); // Try to crash rather than hang on large allocation. ScopedMemoryLimit MemLimit(1000 * 1024 * 1024); // 1GB diff --git a/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp b/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp index 33490de9b0f6c..9431211b03e71 100644 --- a/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp +++ b/clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp @@ -344,7 +344,6 @@ mapInputsToAbsPaths(clang::tooling::CompilationDatabase &CDB, } for (const auto &Cmd : Cmds) { llvm::SmallString<256> CDBPath(Cmd.Filename); - std::string Directory(Cmd.Directory); llvm::sys::fs::make_absolute(Cmd.Directory, CDBPath); CDBToAbsPaths[std::string(CDBPath)] = std::string(AbsPath); } diff --git a/clang-tools-extra/modularize/Modularize.cpp b/clang-tools-extra/modularize/Modularize.cpp index 4bb3bae0503ac..38979cb4d6911 100644 --- a/clang-tools-extra/modularize/Modularize.cpp +++ b/clang-tools-extra/modularize/Modularize.cpp @@ -360,8 +360,6 @@ getModularizeArgumentsAdjuster(DependencyMap &Dependencies) { if (int Count = FileDependents.size()) { for (int Index = 0; Index < Count; ++Index) { NewArgs.push_back("-include"); - std::string File(std::string("\"") + FileDependents[Index] + - std::string("\"")); NewArgs.push_back(FileDependents[Index]); } } diff --git a/clang-tools-extra/modularize/PreprocessorTracker.cpp b/clang-tools-extra/modularize/PreprocessorTracker.cpp index 85e3aab041e49..0c030f1112204 100644 --- a/clang-tools-extra/modularize/PreprocessorTracker.cpp +++ b/clang-tools-extra/modularize/PreprocessorTracker.cpp @@ -381,7 +381,6 @@ static std::string getMacroUnexpandedString(clang::SourceRange Range, clang::SourceLocation BeginLoc(Range.getBegin()); const char *BeginPtr = PP.getSourceManager().getCharacterData(BeginLoc); size_t Length; - std::string Unexpanded; if (MI->isFunctionLike()) { clang::SourceLocation EndLoc(Range.getEnd()); const char *EndPtr = PP.getSourceManager().getCharacterData(EndLoc) + 1; @@ -1328,7 +1327,6 @@ void PreprocessorCallbacks::Defined(const clang::Token &MacroNameTok, clang::SourceLocation Loc(Range.getBegin()); clang::IdentifierInfo *II = MacroNameTok.getIdentifierInfo(); const clang::MacroInfo *MI = MD.getMacroInfo(); - std::string MacroName = II->getName().str(); std::string Unexpanded(getSourceString(PP, Range)); PPTracker.addMacroExpansionInstance( PP, PPTracker.getCurrentHeaderHandle(), Loc, `````````` </details> https://github.com/llvm/llvm-project/pull/139382 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
