AaronBallman wrote: > @AaronBallman oh thanks for the review! one problem at the moment is that the > tests cover features that are dependent on the ptrauth options parsing PR, as > well as the null value authentication work, etc > > I'm not sure the best path forward for dealing with all the interrelations of > these multiple features and multiple tests.
In theory, we support "stacked patches" with GitHub PRs, so we could try those (I've never found them particularly good compared to stacked patches in Phab). IIRC, Graphite may have some utility for stacked patches too. Otherwise, teasing the PRs apart so they're more independent can be helpful to me as a reviewer (though it can be more work for you as a PR author). > We also obviously have to upstream the full pointer auth docs as well, but I > think it makes sense to delay that until we're more confident we have all the > important parts upstreamed/ That makes sense; I'm fine with one big release note at the end so long as we remember to go back and write that note before the branch happens. https://github.com/llvm/llvm-project/pull/138482 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
