Sirraide wrote: > This seems like a good way to do it, since it clearly documents what's going > on. LLVM is the only project I've seen with such a policy; across all of > chromium's dependencies, the extra `virtual` specifiers we flagged were > indeed mistakes. The issue with libc++ was more to do with infrastructure > than the warning itself, IIUC.
Alright, in that case I’d say it would be nice to do that in a follow-up pr so we can stop disabling the warning. https://github.com/llvm/llvm-project/pull/138741 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
