https://github.com/erichkeane approved this pull request.

What do we think @AaronBallman ?  I think the diagnostic column is as best 
effort as we are going to get, so I'm OK with this as-is.  WE could perhaps 
improve that, but I don't think doing that here is worth the effort.

I'll approve, but I want to make sure Aaron has a chance to say otherwise 
before merging.

https://github.com/llvm/llvm-project/pull/133107
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to