aaron.ballman added inline comments.
================ Comment at: lib/Basic/Targets.cpp:4340-4341 llvm::Triple T = llvm::Triple(Triple); - if (T.isWatchOS()) - UseSignedCharForObjCBool = false; + if (!T.isWatchOS()) + UseSignedCharForObjCBool = true; SizeType = UnsignedLong; ---------------- Rather than using an if statement, why not assign directly? `UseSignedCharForObjCBool = !T.isWatchOS();` ================ Comment at: lib/Basic/Targets.cpp:4772-4773 llvm::Triple T = llvm::Triple(Triple); - if (T.isiOS()) - UseSignedCharForObjCBool = false; + if (!T.isiOS()) + UseSignedCharForObjCBool = true; resetDataLayout("e-m:o-i64:64-f80:128-n8:16:32:64-S128"); ---------------- Same here. Repository: rL LLVM https://reviews.llvm.org/D29768 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits