================
@@ -115,6 +115,15 @@ struct ModuleID {
   }
 };
 
+struct ExtendedModuleID {
----------------
cyndyishida wrote:

nit: why not use a `std::pair`? It comes with operator overloads.
Also, assuming this field is only intended for representing objects in 
`ClangModuleDeps`, maybe the type should be named `ClangModuleDepInfo`?

Otherwise, it's not clear to me why & when a `ModuleID` needs to be extended. 

https://github.com/llvm/llvm-project/pull/137421
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to