baloghadamsoftware added a comment.

Thank you for your help.

Actually, I did neither merge the patches nor the checkers. Based on the 
experiences in the prototype I created a totally new checker. Incremental 
development sounds good, but I did a lot of experimenting in this particular 
checker, which means I added things then removed them, I changed things then 
changed them back etc.

I can try to separate that small part (simple_good and simple_bad tests pass), 
but cutting the patch in 12+ parts is overkill. For example, separation of 
insert and emplace is pointless because they affect iterators exactly the same 
way. But I woul also merge them with erase, the patches remain small enough. I 
think 5 parts are more than enough, because review will take weeks, so 
uploading them incrementally one-by-one will take at least half a year.


https://reviews.llvm.org/D31975



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to