Author: Ryosuke Niwa Date: 2025-04-24T17:10:05-07:00 New Revision: 70e303f11e1b9ac4af20d4fad5f1ec1c8ceb448e
URL: https://github.com/llvm/llvm-project/commit/70e303f11e1b9ac4af20d4fad5f1ec1c8ceb448e DIFF: https://github.com/llvm/llvm-project/commit/70e303f11e1b9ac4af20d4fad5f1ec1c8ceb448e.diff LOG: [webkit.UncountedLambdaCapturesChecker] Treat a call to lambda function via a variable as safe. (#135688) This PR makes the checker ignore a function call to lambda via a local variable. Added: Modified: clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp Removed: ################################################################################ diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp index da403d591a2e2..0a658b59ad8c5 100644 --- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp @@ -263,8 +263,6 @@ class RawPtrRefLambdaCapturesChecker return; DeclRefExprsToIgnore.insert(ArgRef); LambdasToIgnore.insert(L); - Checker->visitLambdaExpr(L, shouldCheckThis() && !hasProtectedThis(L), - ClsType, /* ignoreParamVarDecl */ true); } bool hasProtectedThis(LambdaExpr *L) { diff --git a/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp index 36135973e78c0..daa15d55aee5a 100644 --- a/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp +++ b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp @@ -372,6 +372,17 @@ void trivial_lambda() { trivial_lambda(); } +bool call_lambda_var_decl() { + RefCountable* ref_countable = make_obj(); + auto lambda1 = [&]() -> bool { + return ref_countable->next(); + }; + auto lambda2 = [=]() -> bool { + return ref_countable->next(); + }; + return lambda1() && lambda2(); +} + void lambda_with_args(RefCountable* obj) { auto trivial_lambda = [&](int v) { obj->method(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
