https://github.com/AaronBallman commented:
So I think the things that are missing are: 1) If `Insert` or `Remove` is true, we should diagnose those as being deprecated and recommend using `disable-insert` or `disable-remove` instead. 2) A release note should be added to clang-tools-extra/docs/ReleaseNotes.rst so users know about the change and new flags. 3) Test coverage in clang-tools-extra/include-cleaner/test to test that we get the deprecation warning only when expected (for both options) and that the new options behave the same as the old options. https://github.com/llvm/llvm-project/pull/132991 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
