llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> This patch replaces: llvm::copy(Src, std::back_inserter(Dst)); with: llvm::append_range(Dst, Src); for breavity. One side benefit is that llvm::append_range eventually calls llvm::SmallVector::reserve if Dst is of llvm::SmallVector. --- Full diff: https://github.com/llvm/llvm-project/pull/136256.diff 7 Files Affected: - (modified) clang/lib/CodeGen/Targets/AArch64.cpp (+2-2) - (modified) clang/lib/Driver/XRayArgs.cpp (+2-2) - (modified) clang/lib/Sema/SemaConcept.cpp (+2-2) - (modified) clang/lib/Sema/SemaSYCL.cpp (+1-1) - (modified) clang/tools/clang-installapi/ClangInstallAPI.cpp (+1-1) - (modified) clang/tools/clang-installapi/Options.cpp (+2-2) - (modified) clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp (+1-1) ``````````diff diff --git a/clang/lib/CodeGen/Targets/AArch64.cpp b/clang/lib/CodeGen/Targets/AArch64.cpp index 073ca3cc82690..77e225d197343 100644 --- a/clang/lib/CodeGen/Targets/AArch64.cpp +++ b/clang/lib/CodeGen/Targets/AArch64.cpp @@ -699,7 +699,7 @@ bool AArch64ABIInfo::passAsPureScalableType( return false; for (uint64_t I = 0; I < NElt; ++I) - llvm::copy(EltCoerceToSeq, std::back_inserter(CoerceToSeq)); + llvm::append_range(CoerceToSeq, EltCoerceToSeq); NVec += NElt * NV; NPred += NElt * NP; @@ -818,7 +818,7 @@ void AArch64ABIInfo::flattenType( flattenType(AT->getElementType(), EltFlattened); for (uint64_t I = 0; I < NElt; ++I) - llvm::copy(EltFlattened, std::back_inserter(Flattened)); + llvm::append_range(Flattened, EltFlattened); return; } diff --git a/clang/lib/Driver/XRayArgs.cpp b/clang/lib/Driver/XRayArgs.cpp index f8c213334a2b4..6649ed14c3982 100644 --- a/clang/lib/Driver/XRayArgs.cpp +++ b/clang/lib/Driver/XRayArgs.cpp @@ -157,7 +157,7 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) { // Get the list of modes we want to support. auto SpecifiedModes = Args.getAllArgValues(options::OPT_fxray_modes); if (SpecifiedModes.empty()) - llvm::copy(XRaySupportedModes, std::back_inserter(Modes)); + llvm::append_range(Modes, XRaySupportedModes); else for (const auto &Arg : SpecifiedModes) { // Parse CSV values for -fxray-modes=... @@ -167,7 +167,7 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) { if (M == "none") Modes.clear(); else if (M == "all") - llvm::copy(XRaySupportedModes, std::back_inserter(Modes)); + llvm::append_range(Modes, XRaySupportedModes); else Modes.push_back(std::string(M)); } diff --git a/clang/lib/Sema/SemaConcept.cpp b/clang/lib/Sema/SemaConcept.cpp index 73bc8731af57d..5424d207d3c77 100644 --- a/clang/lib/Sema/SemaConcept.cpp +++ b/clang/lib/Sema/SemaConcept.cpp @@ -2012,8 +2012,8 @@ FormulaType SubsumptionChecker::Normalize(const NormalizedConstraint &NC) { for (const auto &RTransform : Right) { Clause Combined; Combined.reserve(LTransform.size() + RTransform.size()); - llvm::copy(LTransform, std::back_inserter(Combined)); - llvm::copy(RTransform, std::back_inserter(Combined)); + llvm::append_range(Combined, LTransform); + llvm::append_range(Combined, RTransform); Add(std::move(Combined)); } } diff --git a/clang/lib/Sema/SemaSYCL.cpp b/clang/lib/Sema/SemaSYCL.cpp index ddd92782366b5..1969d7b0ba837 100644 --- a/clang/lib/Sema/SemaSYCL.cpp +++ b/clang/lib/Sema/SemaSYCL.cpp @@ -135,7 +135,7 @@ void SemaSYCL::deepTypeCheckForDevice(SourceLocation UsedAt, // When nullptr is discovered, this means we've gone back up a level, so // the history should be cleaned. StackForRecursion.push_back(nullptr); - llvm::copy(RecDecl->fields(), std::back_inserter(StackForRecursion)); + llvm::append_range(StackForRecursion, RecDecl->fields()); } } while (!StackForRecursion.empty()); } diff --git a/clang/tools/clang-installapi/ClangInstallAPI.cpp b/clang/tools/clang-installapi/ClangInstallAPI.cpp index ce6240b1b56f1..37b69ccf4e00e 100644 --- a/clang/tools/clang-installapi/ClangInstallAPI.cpp +++ b/clang/tools/clang-installapi/ClangInstallAPI.cpp @@ -59,7 +59,7 @@ static bool runFrontend(StringRef ProgName, Twine Label, bool Verbose, // headers. std::vector<std::string> Args = {ProgName.data(), "-target", Ctx.Slice->getTriple().str().c_str()}; - llvm::copy(InitialArgs, std::back_inserter(Args)); + llvm::append_range(Args, InitialArgs); Args.push_back(InputFile); // Create & run invocation. diff --git a/clang/tools/clang-installapi/Options.cpp b/clang/tools/clang-installapi/Options.cpp index 0dddcfce58ca6..efb36848dbbf1 100644 --- a/clang/tools/clang-installapi/Options.cpp +++ b/clang/tools/clang-installapi/Options.cpp @@ -691,7 +691,7 @@ Options::processAndFilterOutInstallAPIOptions(ArrayRef<const char *> Args) { if (A->getOption().getID() > (unsigned)OPT_UNKNOWN) { ClangDriverArgs.push_back(A->getSpelling().data()); } else - llvm::copy(A->getValues(), std::back_inserter(ClangDriverArgs)); + llvm::append_range(ClangDriverArgs, A->getValues()); } return ClangDriverArgs; } @@ -751,7 +751,7 @@ Options::Options(DiagnosticsEngine &Diag, FileManager *FM, if (A->isClaimed()) continue; FrontendArgs.emplace_back(A->getSpelling()); - llvm::copy(A->getValues(), std::back_inserter(FrontendArgs)); + llvm::append_range(FrontendArgs, A->getValues()); } } diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp index 4e716e818a232..bdeaa2031d184 100644 --- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp +++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp @@ -541,7 +541,7 @@ Expected<StringRef> clang(ArrayRef<StringRef> InputFiles, const ArgList &Args, else Arg->render(Args, LinkerArgs); } - llvm::copy(LinkerArgs, std::back_inserter(CmdArgs)); + llvm::append_range(CmdArgs, LinkerArgs); } // Pass on -mllvm options to the linker invocation. `````````` </details> https://github.com/llvm/llvm-project/pull/136256 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
