EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: CMakeLists.txt:119
+ set(LIBCXX_CXX_ABI_LIBNAME "vcruntime")
else()
+ find_path(
----------------
Nit: I would rather see this be
```
elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND
IS_DIRECTORY "${LIBCXX_LIBCXXABI_INCLUDES_INTERNAL}")
```
That way we can avoid a level of nesting.
https://reviews.llvm.org/D32320
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
