rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land.
I'm not thrilled about adding yet more predefined macros, but it really doesn't make sense for libc++ to depend on `__GCC_*` macros when targeting Windows, nor for these to be Windows-only, so let's do it. ================ Comment at: lib/Frontend/InitPreprocessor.cpp:910-912 + addLockFreeMacros("__CLANG_ATOMIC"); + if (!LangOpts.MSVCCompat) + addLockFreeMacros("__GCC_ATOMIC"); ---------------- I'd sink the `_` into the prefix too, but this looks fine either way. https://reviews.llvm.org/D32265 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits