================
@@ -458,6 +458,8 @@ def warn_compat_pp_embed_directive : Warning<
   InGroup<CPre23Compat>, DefaultIgnore;
 def err_pp_embed_dup_params : Error<
   "cannot specify parameter '%0' twice in the same '#embed' directive">;
+def err_pp_embed_device_file : Error<
+  "device files are not yet supported by '#embed' directive">;
----------------
cor3ntin wrote:

```suggestion
def err_pp_embed_device_file : Error<
  "device files are not supported by '#embed' directive">;
```

Can we remove `yet`? It's unclear that it's a direction that we will ever want 
to go in, and I don't want to set the wrong expectations

https://github.com/llvm/llvm-project/pull/135370
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to