danielmarjamaki added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:337 + const Expr *BlockBytes, + ProgramStateRef State); static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE, ---------------- Thanks for renaming the function I am happy now with that name. :-) hmm.. if you have CheckerContext parameter already then ProgramStateRef parameter seems redundant. You should be able to use C.getState(). However looking at surrounding code it seems you can provide ProgramStateRef for consistency. I don't have a strong opinion, but I would remove this State. Repository: rL LLVM https://reviews.llvm.org/D30771 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
