mstorsjo wrote:

> I'm still not sure about the Win/Darwin part, but otherwise LGTM.

We could fix it by adding a case for armv7 on Darwin in 
`ARM::getARMCPUForArch`, which would allow getting rid of that special case 
here. But as we currently have the special cases for Windows/Darwin here, I 
would rather prefer to not touch that within this change, but do such cleanup 
in a later separate PR.

https://github.com/llvm/llvm-project/pull/134612
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to