hvdijk wrote: > Seems reasonable so long as we know that `SPIR-V` is always a GPU. I'll defer > to SPIR people.
It's not. SPIR-V is mostly-device-agnostic and implementations may run it on GPU, on CPU, or on any other device. I'm looking at this while trying to update 94229, I think `isGPU()` should return `false` for SPIR-V, and instead there should be checks for SYCL rather than for SPIR-V as non-SPIR-V SYCL targets need the same handling, does that sound reasonable to you? https://github.com/llvm/llvm-project/pull/126956 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
