https://github.com/Keenuts updated
https://github.com/llvm/llvm-project/pull/133464
From 12524667594d413c93a2c88a206a930cff638da3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= <brio...@google.com>
Date: Thu, 28 Nov 2024 15:00:56 +0100
Subject: [PATCH 1/6] [SPIR-V] Add hlsl_private address space for SPIR-V
In SPIR-V, private global variables have the Private storage class.
This PR adds a new address space which allows frontend to emit
variable with this storage class when targeting this backend.
This is covered in this proposal: llvm/wg-hlsl@4c9e11a
This PR will cause addrspacecast to show up in several cases, like class
member functions or assignment. Those will have to be handled in the
backend later on, particularly to fixup pointer storage classes in some
functions.
Before this change, global variable were emitted with the 'Function'
storage class, which was wrong.
---
clang/include/clang/Basic/AddressSpaces.h | 1 +
clang/include/clang/Sema/Sema.h | 1 +
clang/lib/AST/Type.cpp | 5 ++
clang/lib/AST/TypePrinter.cpp | 2 +
clang/lib/Basic/TargetInfo.cpp | 2 +
clang/lib/Basic/Targets/AArch64.h | 1 +
clang/lib/Basic/Targets/AMDGPU.cpp | 4 ++
clang/lib/Basic/Targets/DirectX.h | 1 +
clang/lib/Basic/Targets/NVPTX.h | 1 +
clang/lib/Basic/Targets/SPIR.h | 48 ++++++++++---------
clang/lib/Basic/Targets/SystemZ.h | 1 +
clang/lib/Basic/Targets/TCE.h | 1 +
clang/lib/Basic/Targets/WebAssembly.h | 1 +
clang/lib/Basic/Targets/X86.h | 1 +
clang/lib/CodeGen/CGDeclCXX.cpp | 16 ++++++-
clang/lib/CodeGen/CodeGenFunction.cpp | 12 ++---
clang/lib/Sema/SemaDecl.cpp | 35 ++++++++++++++
clang/test/AST/HLSL/cbuffer.hlsl | 2 +-
.../test/CodeGenHLSL/GlobalConstructors.hlsl | 15 ++++--
...uffer_with_static_global_and_function.hlsl | 1 +
.../test/CodeGenHLSL/out-of-line-static.hlsl | 30 ++++++++++++
clang/test/CodeGenHLSL/static-variable.hlsl | 18 +++++++
.../SemaTemplate/address_space-dependent.cpp | 4 +-
llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp | 3 ++
24 files changed, 169 insertions(+), 37 deletions(-)
create mode 100644 clang/test/CodeGenHLSL/out-of-line-static.hlsl
create mode 100644 clang/test/CodeGenHLSL/static-variable.hlsl
diff --git a/clang/include/clang/Basic/AddressSpaces.h
b/clang/include/clang/Basic/AddressSpaces.h
index d18bfe54931f9..5787e6dac0e36 100644
--- a/clang/include/clang/Basic/AddressSpaces.h
+++ b/clang/include/clang/Basic/AddressSpaces.h
@@ -59,6 +59,7 @@ enum class LangAS : unsigned {
// HLSL specific address spaces.
hlsl_groupshared,
hlsl_constant,
+ hlsl_private,
// Wasm specific address spaces.
wasm_funcref,
diff --git a/clang/include/clang/Sema/Sema.h b/clang/include/clang/Sema/Sema.h
index 7bd77d33a1f3d..94b3792d25350 100644
--- a/clang/include/clang/Sema/Sema.h
+++ b/clang/include/clang/Sema/Sema.h
@@ -4328,6 +4328,7 @@ class Sema final : public SemaBase {
NamedDecl *findLocallyScopedExternCDecl(DeclarationName Name);
void deduceOpenCLAddressSpace(ValueDecl *decl);
+ void deduceHLSLAddressSpace(VarDecl *decl);
/// Adjust the \c DeclContext for a function or variable that might be a
/// function-local external declaration.
diff --git a/clang/lib/AST/Type.cpp b/clang/lib/AST/Type.cpp
index 4336fe44b82ad..dcdb0104f0224 100644
--- a/clang/lib/AST/Type.cpp
+++ b/clang/lib/AST/Type.cpp
@@ -94,6 +94,8 @@ bool Qualifiers::isTargetAddressSpaceSupersetOf(LangAS A,
LangAS B,
(A == LangAS::Default &&
(B == LangAS::cuda_constant || B == LangAS::cuda_device ||
B == LangAS::cuda_shared)) ||
+ // Default is a superset of HLSL private.
+ (A == LangAS::Default && B == LangAS::hlsl_private) ||
// Conversions from target specific address spaces may be legal
// depending on the target information.
Ctx.getTargetInfo().isAddressSpaceSupersetOf(A, B);
@@ -5168,6 +5170,9 @@ bool Type::isHLSLIntangibleType() const {
CXXRecordDecl *RD = RT->getAsCXXRecordDecl();
assert(RD != nullptr &&
"all HLSL structs and classes should be CXXRecordDecl");
+
+ if (!RD->isCompleteDefinition())
+ return false;
assert(RD->isCompleteDefinition() && "expecting complete type");
return RD->isHLSLIntangible();
}
diff --git a/clang/lib/AST/TypePrinter.cpp b/clang/lib/AST/TypePrinter.cpp
index 4ec252e3f89b5..4f2b00d19a446 100644
--- a/clang/lib/AST/TypePrinter.cpp
+++ b/clang/lib/AST/TypePrinter.cpp
@@ -2581,6 +2581,8 @@ std::string Qualifiers::getAddrSpaceAsString(LangAS AS) {
return "groupshared";
case LangAS::hlsl_constant:
return "hlsl_constant";
+ case LangAS::hlsl_private:
+ return "hlsl_private";
case LangAS::wasm_funcref:
return "__funcref";
default:
diff --git a/clang/lib/Basic/TargetInfo.cpp b/clang/lib/Basic/TargetInfo.cpp
index 0699ec686e4e6..ab13c32f6943e 100644
--- a/clang/lib/Basic/TargetInfo.cpp
+++ b/clang/lib/Basic/TargetInfo.cpp
@@ -47,6 +47,8 @@ static const LangASMap FakeAddrSpaceMap = {
11, // ptr32_uptr
12, // ptr64
13, // hlsl_groupshared
+ 14, // hlsl_constant
+ 15, // hlsl_private
20, // wasm_funcref
};
diff --git a/clang/lib/Basic/Targets/AArch64.h
b/clang/lib/Basic/Targets/AArch64.h
index 9b6451bd06316..58822e467ce39 100644
--- a/clang/lib/Basic/Targets/AArch64.h
+++ b/clang/lib/Basic/Targets/AArch64.h
@@ -45,6 +45,7 @@ static const unsigned ARM64AddrSpaceMap[] = {
static_cast<unsigned>(AArch64AddrSpace::ptr64),
0, // hlsl_groupshared
0, // hlsl_constant
+ 0, // hlsl_private
// Wasm address space values for this target are dummy values,
// as it is only enabled for Wasm targets.
20, // wasm_funcref
diff --git a/clang/lib/Basic/Targets/AMDGPU.cpp
b/clang/lib/Basic/Targets/AMDGPU.cpp
index c57a70bf6e587..f81cdac3b7422 100644
--- a/clang/lib/Basic/Targets/AMDGPU.cpp
+++ b/clang/lib/Basic/Targets/AMDGPU.cpp
@@ -60,6 +60,9 @@ const LangASMap AMDGPUTargetInfo::AMDGPUDefIsGenMap = {
llvm::AMDGPUAS::FLAT_ADDRESS, // ptr64
llvm::AMDGPUAS::FLAT_ADDRESS, // hlsl_groupshared
llvm::AMDGPUAS::CONSTANT_ADDRESS, // hlsl_constant
+ // FIXME(pr/122103): hlsl_private -> PRIVATE is wrong, but at least this
+ // will break loudly.
+ llvm::AMDGPUAS::PRIVATE_ADDRESS, // hlsl_private
};
const LangASMap AMDGPUTargetInfo::AMDGPUDefIsPrivMap = {
@@ -85,6 +88,7 @@ const LangASMap AMDGPUTargetInfo::AMDGPUDefIsPrivMap = {
llvm::AMDGPUAS::FLAT_ADDRESS, // ptr64
llvm::AMDGPUAS::FLAT_ADDRESS, // hlsl_groupshared
llvm::AMDGPUAS::CONSTANT_ADDRESS, // hlsl_constant
+ llvm::AMDGPUAS::PRIVATE_ADDRESS, // hlsl_private
};
} // namespace targets
} // namespace clang
diff --git a/clang/lib/Basic/Targets/DirectX.h
b/clang/lib/Basic/Targets/DirectX.h
index 0e88a37e32493..4ff66cdd9f8fa 100644
--- a/clang/lib/Basic/Targets/DirectX.h
+++ b/clang/lib/Basic/Targets/DirectX.h
@@ -43,6 +43,7 @@ static const unsigned DirectXAddrSpaceMap[] = {
0, // ptr64
3, // hlsl_groupshared
2, // hlsl_constant
+ 0, // hlsl_private
// Wasm address space values for this target are dummy values,
// as it is only enabled for Wasm targets.
20, // wasm_funcref
diff --git a/clang/lib/Basic/Targets/NVPTX.h b/clang/lib/Basic/Targets/NVPTX.h
index 6a868c42e1265..041596929ff5b 100644
--- a/clang/lib/Basic/Targets/NVPTX.h
+++ b/clang/lib/Basic/Targets/NVPTX.h
@@ -47,6 +47,7 @@ static const unsigned NVPTXAddrSpaceMap[] = {
0, // ptr64
0, // hlsl_groupshared
0, // hlsl_constant
+ 0, // hlsl_private
// Wasm address space values for this target are dummy values,
// as it is only enabled for Wasm targets.
20, // wasm_funcref
diff --git a/clang/lib/Basic/Targets/SPIR.h b/clang/lib/Basic/Targets/SPIR.h
index 78505d66d6f2f..c71f046c8e180 100644
--- a/clang/lib/Basic/Targets/SPIR.h
+++ b/clang/lib/Basic/Targets/SPIR.h
@@ -38,16 +38,17 @@ static const unsigned SPIRDefIsPrivMap[] = {
0, // cuda_constant
0, // cuda_shared
// SYCL address space values for this map are dummy
- 0, // sycl_global
- 0, // sycl_global_device
- 0, // sycl_global_host
- 0, // sycl_local
- 0, // sycl_private
- 0, // ptr32_sptr
- 0, // ptr32_uptr
- 0, // ptr64
- 0, // hlsl_groupshared
- 2, // hlsl_constant
+ 0, // sycl_global
+ 0, // sycl_global_device
+ 0, // sycl_global_host
+ 0, // sycl_local
+ 0, // sycl_private
+ 0, // ptr32_sptr
+ 0, // ptr32_uptr
+ 0, // ptr64
+ 0, // hlsl_groupshared
+ 2, // hlsl_constant
+ 10, // hlsl_private
// Wasm address space values for this target are dummy values,
// as it is only enabled for Wasm targets.
20, // wasm_funcref
@@ -70,18 +71,19 @@ static const unsigned SPIRDefIsGenMap[] = {
// cuda_constant pointer can be casted to default/"flat" pointer, but in
// SPIR-V casts between constant and generic pointers are not allowed. For
// this reason cuda_constant is mapped to SPIR-V CrossWorkgroup.
- 1, // cuda_constant
- 3, // cuda_shared
- 1, // sycl_global
- 5, // sycl_global_device
- 6, // sycl_global_host
- 3, // sycl_local
- 0, // sycl_private
- 0, // ptr32_sptr
- 0, // ptr32_uptr
- 0, // ptr64
- 0, // hlsl_groupshared
- 0, // hlsl_constant
+ 1, // cuda_constant
+ 3, // cuda_shared
+ 1, // sycl_global
+ 5, // sycl_global_device
+ 6, // sycl_global_host
+ 3, // sycl_local
+ 0, // sycl_private
+ 0, // ptr32_sptr
+ 0, // ptr32_uptr
+ 0, // ptr64
+ 0, // hlsl_groupshared
+ 0, // hlsl_constant
+ 10, // hlsl_private
// Wasm address space values for this target are dummy values,
// as it is only enabled for Wasm targets.
20, // wasm_funcref
@@ -315,7 +317,7 @@ class LLVM_LIBRARY_VISIBILITY SPIRVTargetInfo : public
BaseSPIRVTargetInfo {
// SPIR-V IDs are represented with a single 32-bit word.
SizeType = TargetInfo::UnsignedInt;
resetDataLayout("e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-"
- "v256:256-v512:512-v1024:1024-n8:16:32:64-G1");
+ "v256:256-v512:512-v1024:1024-n8:16:32:64-G10");
}
llvm::SmallVector<Builtin::InfosShard> getTargetBuiltins() const override;
diff --git a/clang/lib/Basic/Targets/SystemZ.h
b/clang/lib/Basic/Targets/SystemZ.h
index 4ca3f53f83cba..4d1509b84e82b 100644
--- a/clang/lib/Basic/Targets/SystemZ.h
+++ b/clang/lib/Basic/Targets/SystemZ.h
@@ -43,6 +43,7 @@ static const unsigned ZOSAddressMap[] = {
0, // ptr64
0, // hlsl_groupshared
0, // hlsl_constant
+ 0, // hlsl_private
0 // wasm_funcref
};
diff --git a/clang/lib/Basic/Targets/TCE.h b/clang/lib/Basic/Targets/TCE.h
index 46c70de8f9ec1..44de8aae52a16 100644
--- a/clang/lib/Basic/Targets/TCE.h
+++ b/clang/lib/Basic/Targets/TCE.h
@@ -52,6 +52,7 @@ static const unsigned TCEOpenCLAddrSpaceMap[] = {
0, // ptr64
0, // hlsl_groupshared
0, // hlsl_constant
+ 0, // hlsl_private
// Wasm address space values for this target are dummy values,
// as it is only enabled for Wasm targets.
20, // wasm_funcref
diff --git a/clang/lib/Basic/Targets/WebAssembly.h
b/clang/lib/Basic/Targets/WebAssembly.h
index fb48c786a7edb..e786f9a3db68e 100644
--- a/clang/lib/Basic/Targets/WebAssembly.h
+++ b/clang/lib/Basic/Targets/WebAssembly.h
@@ -43,6 +43,7 @@ static const unsigned WebAssemblyAddrSpaceMap[] = {
0, // ptr64
0, // hlsl_groupshared
0, // hlsl_constant
+ 0, // hlsl_private
20, // wasm_funcref
};
diff --git a/clang/lib/Basic/Targets/X86.h b/clang/lib/Basic/Targets/X86.h
index 205edcab9ccb3..d44561dd42997 100644
--- a/clang/lib/Basic/Targets/X86.h
+++ b/clang/lib/Basic/Targets/X86.h
@@ -47,6 +47,7 @@ static const unsigned X86AddrSpaceMap[] = {
272, // ptr64
0, // hlsl_groupshared
0, // hlsl_constant
+ 0, // hlsl_private
// Wasm address space values for this target are dummy values,
// as it is only enabled for Wasm targets.
20, // wasm_funcref
diff --git a/clang/lib/CodeGen/CGDeclCXX.cpp b/clang/lib/CodeGen/CGDeclCXX.cpp
index e0921993bd14e..303d21e6152fe 100644
--- a/clang/lib/CodeGen/CGDeclCXX.cpp
+++ b/clang/lib/CodeGen/CGDeclCXX.cpp
@@ -1157,8 +1157,22 @@ void CodeGenFunction::GenerateCXXGlobalCleanUpFunc(
CGM.getCXXABI().useSinitAndSterm() &&
"Arg could not be nullptr unless using sinit and sterm
functions.");
CI = Builder.CreateCall(CalleeTy, Callee);
- } else
+ } else {
+ // If the object lives in a different address space, the `this` pointer
+ // address space won't match the dtor `this` param. An addrspacecast is
+ // required.
+ assert(Arg->getType()->isPointerTy());
+ assert(CalleeTy->getParamType(0)->isPointerTy());
+ unsigned ActualAddrSpace = Arg->getType()->getPointerAddressSpace();
+ unsigned ExpectedAddrSpace =
+ CalleeTy->getParamType(0)->getPointerAddressSpace();
+ if (ActualAddrSpace != ExpectedAddrSpace) {
+ llvm::PointerType *PTy =
+ llvm::PointerType::get(getLLVMContext(), ExpectedAddrSpace);
+ Arg = llvm::ConstantExpr::getAddrSpaceCast(Arg, PTy);
+ }
CI = Builder.CreateCall(CalleeTy, Callee, Arg);
+ }
// Make sure the call and the callee agree on calling convention.
if (llvm::Function *F = dyn_cast<llvm::Function>(Callee))
diff --git a/clang/lib/CodeGen/CodeGenFunction.cpp
b/clang/lib/CodeGen/CodeGenFunction.cpp
index 232d48141a0c0..9b36a27ccb248 100644
--- a/clang/lib/CodeGen/CodeGenFunction.cpp
+++ b/clang/lib/CodeGen/CodeGenFunction.cpp
@@ -371,12 +371,6 @@ void CodeGenFunction::FinishFunction(SourceLocation
EndLoc) {
assert(DeferredDeactivationCleanupStack.empty() &&
"mismatched activate/deactivate of cleanups!");
- if (CGM.shouldEmitConvergenceTokens()) {
- ConvergenceTokenStack.pop_back();
- assert(ConvergenceTokenStack.empty() &&
- "mismatched push/pop in convergence stack!");
- }
-
bool OnlySimpleReturnStmts = NumSimpleReturnExprs > 0
&& NumSimpleReturnExprs == NumReturnExprs
&& ReturnBlock.getBlock()->use_empty();
@@ -564,6 +558,12 @@ void CodeGenFunction::FinishFunction(SourceLocation
EndLoc) {
ReturnValue = Address::invalid();
}
}
+
+ if (CGM.shouldEmitConvergenceTokens()) {
+ ConvergenceTokenStack.pop_back();
+ assert(ConvergenceTokenStack.empty() &&
+ "mismatched push/pop in convergence stack!");
+ }
}
/// ShouldInstrumentFunction - Return true if the current function should be
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index 540f5f23fe89a..fec941d9cbf0f 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -6888,6 +6888,32 @@ static void SetNestedNameSpecifier(Sema &S,
DeclaratorDecl *DD, Declarator &D) {
DD->setQualifierInfo(SS.getWithLocInContext(S.Context));
}
+void Sema::deduceHLSLAddressSpace(VarDecl *Decl) {
+ // The variable already has an address space (groupshared for ex).
+ if (Decl->getType().hasAddressSpace())
+ return;
+
+ if (Decl->getType()->isDependentType())
+ return;
+
+ QualType Type = Decl->getType();
+ if (Type->isSamplerT() || Type->isVoidType())
+ return;
+
+ // Resource handles.
+ if (Type->isHLSLIntangibleType())
+ return;
+
+ // Only static globals belong to the Private address space.
+ // Non-static globals belongs to the cbuffer.
+ if (Decl->getStorageClass() != SC_Static && !Decl->isStaticDataMember())
+ return;
+
+ LangAS ImplAS = LangAS::hlsl_private;
+ Type = Context.getAddrSpaceQualType(Type, ImplAS);
+ Decl->setType(Type);
+}
+
void Sema::deduceOpenCLAddressSpace(ValueDecl *Decl) {
if (Decl->getType().hasAddressSpace())
return;
@@ -7776,6 +7802,9 @@ NamedDecl *Sema::ActOnVariableDeclarator(
NewVD = VarDecl::Create(Context, DC, D.getBeginLoc(),
D.getIdentifierLoc(), II, R, TInfo, SC);
+ if (getLangOpts().HLSL)
+ deduceHLSLAddressSpace(NewVD);
+
// If this is supposed to be a variable template, create it as such.
if (IsVariableTemplate) {
NewTemplate =
@@ -7960,6 +7989,9 @@ NamedDecl *Sema::ActOnVariableDeclarator(
}
}
+ if (getLangOpts().HLSL)
+ deduceHLSLAddressSpace(NewVD);
+
// WebAssembly tables are always in address space 1 (wasm_var). Don't apply
// address space if the table has local storage (semantic checks elsewhere
// will produce an error anyway).
@@ -13131,6 +13163,9 @@ bool Sema::DeduceVariableDeclarationType(VarDecl
*VDecl, bool DirectInit,
if (getLangOpts().OpenCL)
deduceOpenCLAddressSpace(VDecl);
+ if (getLangOpts().HLSL)
+ deduceHLSLAddressSpace(VDecl);
+
// If this is a redeclaration, check that the type we just deduced matches
// the previously declared type.
if (VarDecl *Old = VDecl->getPreviousDecl()) {
diff --git a/clang/test/AST/HLSL/cbuffer.hlsl b/clang/test/AST/HLSL/cbuffer.hlsl
index 6c573034a4f7b..5c5aa6fc5ab10 100644
--- a/clang/test/AST/HLSL/cbuffer.hlsl
+++ b/clang/test/AST/HLSL/cbuffer.hlsl
@@ -149,7 +149,7 @@
_Static_assert(__builtin_hlsl_is_scalarized_layout_compatible(TwoFloats, __cblay
cbuffer CB {
// CHECK: FunctionDecl {{.*}} f 'void ()'
void f() {}
- // CHECK: VarDecl {{.*}} SV 'float' static
+ // CHECK: VarDecl {{.*}} SV 'hlsl_private float' static
static float SV;
// CHECK: VarDecl {{.*}} s7 'EmptyStruct' callinit
EmptyStruct s7;
diff --git a/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
b/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
index 7b26dba0d1901..602234973c312 100644
--- a/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
+++ b/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
@@ -1,4 +1,5 @@
-// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -emit-llvm
-disable-llvm-passes %s -o - | FileCheck %s
+// RUN: %clang_cc1 -triple spirv-unknown-vulkan1.3-compute -x hlsl -emit-llvm
-disable-llvm-passes %s -o - | FileCheck %s --check-prefixes=CHECK,SPIRV
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -emit-llvm
-disable-llvm-passes %s -o - | FileCheck %s --check-prefixes=CHECK,DXIL
RWBuffer<float> Buffer;
@@ -10,7 +11,13 @@ void main(unsigned GI : SV_GroupIndex) {}
// CHECK-NOT:@llvm.global_dtors
//CHECK: define void @main()
//CHECK-NEXT: entry:
-//CHECK-NEXT: call void @_GLOBAL__sub_I_GlobalConstructors.hlsl()
-//CHECK-NEXT: %0 = call i32 @llvm.dx.flattened.thread.id.in.group()
-//CHECK-NEXT: call void @_Z4mainj(i32 %0)
+
+//SPIRV-NEXT: %0 = call token @llvm.experimental.convergence.entry()
+//SPIRV-NEXT: call spir_func void @_GLOBAL__sub_I_GlobalConstructors.hlsl()
[ "convergencectrl"(token %0) ]
+//SPIRV-NEXT: %1 = call i32 @llvm.spv.flattened.thread.id.in.group()
+//SPIRV-NEXT: call spir_func void @_Z4mainj(i32 %1) [
"convergencectrl"(token %0) ]
+
+//DXIL-NEXT: call void @_GLOBAL__sub_I_GlobalConstructors.hlsl()
+//DXIL-NEXT: %0 = call i32 @llvm.dx.flattened.thread.id.in.group()
+//DXIL-NEXT: call void @_Z4mainj(i32 %0)
//CHECK-NEXT: ret void
diff --git
a/clang/test/CodeGenHLSL/cbuffer_with_static_global_and_function.hlsl
b/clang/test/CodeGenHLSL/cbuffer_with_static_global_and_function.hlsl
index c9c3ee9c43f6e..5eecfc41579f2 100644
--- a/clang/test/CodeGenHLSL/cbuffer_with_static_global_and_function.hlsl
+++ b/clang/test/CodeGenHLSL/cbuffer_with_static_global_and_function.hlsl
@@ -20,6 +20,7 @@ cbuffer B {
// CHECK: define {{.*}} float @_Z3foov() #0 {
// CHECK: load float, ptr addrspace(2) @a, align 4
+// CHECK: load float, ptr @_ZL1b, align 4
extern float bar() {
return foo();
diff --git a/clang/test/CodeGenHLSL/out-of-line-static.hlsl
b/clang/test/CodeGenHLSL/out-of-line-static.hlsl
new file mode 100644
index 0000000000000..8127a6c2ec1e4
--- /dev/null
+++ b/clang/test/CodeGenHLSL/out-of-line-static.hlsl
@@ -0,0 +1,30 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -std=hlsl202x
-emit-llvm -o - -disable-llvm-passes %s | FileCheck %s
--check-prefixes=CHECK,DXIL
+// RUN: %clang_cc1 -triple spirv-pc-vulkan1.3-compute -std=hlsl202x -emit-llvm
-o - -disable-llvm-passes %s | FileCheck %s --check-prefixes=CHECK,SPIRV
+
+struct S {
+ static int Value;
+};
+
+int S::Value = 1;
+// DXIL: @_ZN1S5ValueE = global i32 1, align 4
+// SPIRV: @_ZN1S5ValueE = addrspace(10) global i32 1, align 4
+
+[shader("compute")]
+[numthreads(1,1,1)]
+void main() {
+ S s;
+ int value1, value2;
+// CHECK: %s = alloca %struct.S, align 1
+// CHECK: %value1 = alloca i32, align 4
+// CHECK: %value2 = alloca i32, align 4
+
+// DXIL: [[tmp:%.*]] = load i32, ptr @_ZN1S5ValueE, align 4
+// SPIRV: [[tmp:%.*]] = load i32, ptr addrspace(10) @_ZN1S5ValueE, align 4
+// CHECK: store i32 [[tmp]], ptr %value1, align 4
+ value1 = S::Value;
+
+// DXIL: [[tmp:%.*]] = load i32, ptr @_ZN1S5ValueE, align 4
+// SPIRV: [[tmp:%.*]] = load i32, ptr addrspace(10) @_ZN1S5ValueE, align 4
+// CHECK: store i32 [[tmp]], ptr %value2, align 4
+ value2 = s.Value;
+}
diff --git a/clang/test/CodeGenHLSL/static-variable.hlsl
b/clang/test/CodeGenHLSL/static-variable.hlsl
new file mode 100644
index 0000000000000..4be909d45bae4
--- /dev/null
+++ b/clang/test/CodeGenHLSL/static-variable.hlsl
@@ -0,0 +1,18 @@
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \
+// RUN: spirv-unknown-vulkan1.3-library %s \
+// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s
--check-prefix=SPIRV
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \
+// RUN: dxil-pc-shadermodel6.3-library %s \
+// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s
--check-prefix=DXIL
+
+// DXIL: @_ZL1g = internal global float 0.000000e+00, align 4
+// SPIRV: @_ZL1g = internal addrspace(10) global float 0.000000e+00, align 4
+
+static float g = 0;
+
+[numthreads(8,8,1)]
+void main() {
+// DXIL: {{.*}} = load float, ptr @_ZL1g, align 4
+// SPIRV: {{.*}} = load float, ptr addrspace(10) @_ZL1g, align 4
+ float l = g;
+}
diff --git a/clang/test/SemaTemplate/address_space-dependent.cpp
b/clang/test/SemaTemplate/address_space-dependent.cpp
index eb8dbc69a945e..3e73e909746a5 100644
--- a/clang/test/SemaTemplate/address_space-dependent.cpp
+++ b/clang/test/SemaTemplate/address_space-dependent.cpp
@@ -43,7 +43,7 @@ void neg() {
template <long int I>
void tooBig() {
- __attribute__((address_space(I))) int *bounds; // expected-error {{address
space is larger than the maximum supported (8388585)}}
+ __attribute__((address_space(I))) int *bounds; // expected-error {{address
space is larger than the maximum supported (8388584)}}
}
template <long int I>
@@ -101,7 +101,7 @@ int main() {
car<1, 2, 3>(); // expected-note {{in instantiation of function template
specialization 'car<1, 2, 3>' requested here}}
HasASTemplateFields<1> HASTF;
neg<-1>(); // expected-note {{in instantiation of function template
specialization 'neg<-1>' requested here}}
- correct<0x7FFFE9>();
+ correct<0x7FFFE8>();
tooBig<8388650>(); // expected-note {{in instantiation of function template
specialization 'tooBig<8388650L>' requested here}}
__attribute__((address_space(1))) char *x;
diff --git a/llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp
b/llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp
index 4399f080f1f81..68286737b972f 100644
--- a/llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp
@@ -70,6 +70,9 @@ static std::string computeDataLayout(const Triple &TT) {
if (Arch == Triple::spirv32)
return "e-p:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-"
"v256:256-v512:512-v1024:1024-n8:16:32:64-G1";
+ if (Arch == Triple::spirv)
+ return "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-"
+ "v512:512-v1024:1024-n8:16:32:64-G10";
if (TT.getVendor() == Triple::VendorType::AMD &&
TT.getOS() == Triple::OSType::AMDHSA)
return "e-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-"
From 8c85c82b35ac4c9a9dc19221f6aee41a0dba12cc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= <brio...@google.com>
Date: Tue, 1 Apr 2025 18:21:36 +0200
Subject: [PATCH 2/6] pr-feedback
---
clang/lib/AST/Type.cpp | 3 ---
clang/lib/Sema/SemaDecl.cpp | 21 +++++++++++++-------
clang/test/AST/HLSL/private.hlsl | 34 ++++++++++++++++++++++++++++++++
3 files changed, 48 insertions(+), 10 deletions(-)
create mode 100644 clang/test/AST/HLSL/private.hlsl
diff --git a/clang/lib/AST/Type.cpp b/clang/lib/AST/Type.cpp
index dcdb0104f0224..a36819d891a14 100644
--- a/clang/lib/AST/Type.cpp
+++ b/clang/lib/AST/Type.cpp
@@ -5170,9 +5170,6 @@ bool Type::isHLSLIntangibleType() const {
CXXRecordDecl *RD = RT->getAsCXXRecordDecl();
assert(RD != nullptr &&
"all HLSL structs and classes should be CXXRecordDecl");
-
- if (!RD->isCompleteDefinition())
- return false;
assert(RD->isCompleteDefinition() && "expecting complete type");
return RD->isHLSLIntangible();
}
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index fec941d9cbf0f..b610d6810c612 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -6900,6 +6900,16 @@ void Sema::deduceHLSLAddressSpace(VarDecl *Decl) {
if (Type->isSamplerT() || Type->isVoidType())
return;
+ // Template instantiations can lack definition. In such case,
+ // we cannot deduce the AS.
+ // FIXME: figure out why RWBuffer<float> yields such declaration.
+ if (const RecordType *RT =
+ dyn_cast<RecordType>(Type->getUnqualifiedDesugaredType())) {
+ CXXRecordDecl *RD = Type->getAsCXXRecordDecl();
+ if (RD && !RD->isCompleteDefinition())
+ return;
+ }
+
// Resource handles.
if (Type->isHLSLIntangibleType())
return;
@@ -7802,9 +7812,6 @@ NamedDecl *Sema::ActOnVariableDeclarator(
NewVD = VarDecl::Create(Context, DC, D.getBeginLoc(),
D.getIdentifierLoc(), II, R, TInfo, SC);
- if (getLangOpts().HLSL)
- deduceHLSLAddressSpace(NewVD);
-
// If this is supposed to be a variable template, create it as such.
if (IsVariableTemplate) {
NewTemplate =
@@ -7989,9 +7996,6 @@ NamedDecl *Sema::ActOnVariableDeclarator(
}
}
- if (getLangOpts().HLSL)
- deduceHLSLAddressSpace(NewVD);
-
// WebAssembly tables are always in address space 1 (wasm_var). Don't apply
// address space if the table has local storage (semantic checks elsewhere
// will produce an error anyway).
@@ -8007,8 +8011,11 @@ NamedDecl *Sema::ActOnVariableDeclarator(
// Handle attributes prior to checking for duplicates in MergeVarDecl
ProcessDeclAttributes(S, NewVD, D);
- if (getLangOpts().HLSL)
+ if (getLangOpts().HLSL) {
HLSL().ActOnVariableDeclarator(NewVD);
+ deduceHLSLAddressSpace(NewVD);
+ }
+
if (getLangOpts().OpenACC)
OpenACC().ActOnVariableDeclarator(NewVD);
diff --git a/clang/test/AST/HLSL/private.hlsl b/clang/test/AST/HLSL/private.hlsl
new file mode 100644
index 0000000000000..e00afb8f5cbd8
--- /dev/null
+++ b/clang/test/AST/HLSL/private.hlsl
@@ -0,0 +1,34 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -ast-dump -o - %s |
FileCheck %s
+
+// CHECK: VarDecl {{.*}} global_scalar 'hlsl_private int' static cinit
+static int global_scalar = 0;
+
+// CHECK: VarDecl {{.*}} global_buffer
'RWBuffer<float>':'hlsl::RWBuffer<float>' static callinit
+RWBuffer<float> global_buffer;
+
+class A {
+// CHECK: VarDecl {{.*}} a 'hlsl_private int' static
+ static int a;
+};
+
+class B {
+// CHECK: VarDecl {{.*}} b 'hlsl_private int' static
+ static int b;
+};
+
+// CHECK: VarDecl {{.*}} b 'hlsl_private int' cinit
+int B::b = 0;
+
+export void foo() {
+// CHECK: VarDecl {{.*}} local_buffer
'RWBuffer<float>':'hlsl::RWBuffer<float>' cinit
+ RWBuffer<float> local_buffer = global_buffer;
+
+// CHECK: VarDecl {{.*}} static_local_buffer
'RWBuffer<float>':'hlsl::RWBuffer<float>' static cinit
+ static RWBuffer<float> static_local_buffer = global_buffer;
+
+// CHECK: VarDecl {{.*}} local_scalar 'int' cinit
+ int local_scalar = global_scalar;
+
+// CHECK: VarDecl {{.*}} static_scalar 'hlsl_private int' static cinit
+ static int static_scalar = 0;
+}
From 75d9db5a06df746dcc70d80da0c1c1ece4e46112 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= <brio...@google.com>
Date: Tue, 1 Apr 2025 18:31:11 +0200
Subject: [PATCH 3/6] change comment
---
clang/lib/AST/Type.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/clang/lib/AST/Type.cpp b/clang/lib/AST/Type.cpp
index a36819d891a14..f6dffeb0a1a8f 100644
--- a/clang/lib/AST/Type.cpp
+++ b/clang/lib/AST/Type.cpp
@@ -94,7 +94,9 @@ bool Qualifiers::isTargetAddressSpaceSupersetOf(LangAS A,
LangAS B,
(A == LangAS::Default &&
(B == LangAS::cuda_constant || B == LangAS::cuda_device ||
B == LangAS::cuda_shared)) ||
- // Default is a superset of HLSL private.
+ // `this` overloading depending on address space is not ready,
+ // so this is a hack to allow generating addrspacecasts.
+ // IR legalization will be required when this address space is used.
(A == LangAS::Default && B == LangAS::hlsl_private) ||
// Conversions from target specific address spaces may be legal
// depending on the target information.
From 99919040b8a80549e9e2c7a94fc95ea5d08ed607 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= <brio...@google.com>
Date: Wed, 9 Apr 2025 16:25:41 +0200
Subject: [PATCH 4/6] pr-feedback
---
clang/include/clang/Sema/SemaHLSL.h | 2 +
clang/lib/CodeGen/CodeGenFunction.cpp | 12 +++---
clang/lib/Sema/SemaDecl.cpp | 42 +------------------
clang/lib/Sema/SemaHLSL.cpp | 40 ++++++++++++++++++
.../test/CodeGenHLSL/GlobalConstructors.hlsl | 15 ++-----
clang/test/CodeGenHLSL/GlobalDestructors.hlsl | 2 +-
6 files changed, 55 insertions(+), 58 deletions(-)
diff --git a/clang/include/clang/Sema/SemaHLSL.h
b/clang/include/clang/Sema/SemaHLSL.h
index f333fe30e8da0..10ffb9629bb0e 100644
--- a/clang/include/clang/Sema/SemaHLSL.h
+++ b/clang/include/clang/Sema/SemaHLSL.h
@@ -154,6 +154,8 @@ class SemaHLSL : public SemaBase {
bool TransformInitList(const InitializedEntity &Entity,
const InitializationKind &Kind, InitListExpr *Init);
+ void deduceAddressSpace(VarDecl *Decl);
+
private:
// HLSL resource type attributes need to be processed all at once.
// This is a list to collect them.
diff --git a/clang/lib/CodeGen/CodeGenFunction.cpp
b/clang/lib/CodeGen/CodeGenFunction.cpp
index 9b36a27ccb248..232d48141a0c0 100644
--- a/clang/lib/CodeGen/CodeGenFunction.cpp
+++ b/clang/lib/CodeGen/CodeGenFunction.cpp
@@ -371,6 +371,12 @@ void CodeGenFunction::FinishFunction(SourceLocation
EndLoc) {
assert(DeferredDeactivationCleanupStack.empty() &&
"mismatched activate/deactivate of cleanups!");
+ if (CGM.shouldEmitConvergenceTokens()) {
+ ConvergenceTokenStack.pop_back();
+ assert(ConvergenceTokenStack.empty() &&
+ "mismatched push/pop in convergence stack!");
+ }
+
bool OnlySimpleReturnStmts = NumSimpleReturnExprs > 0
&& NumSimpleReturnExprs == NumReturnExprs
&& ReturnBlock.getBlock()->use_empty();
@@ -558,12 +564,6 @@ void CodeGenFunction::FinishFunction(SourceLocation
EndLoc) {
ReturnValue = Address::invalid();
}
}
-
- if (CGM.shouldEmitConvergenceTokens()) {
- ConvergenceTokenStack.pop_back();
- assert(ConvergenceTokenStack.empty() &&
- "mismatched push/pop in convergence stack!");
- }
}
/// ShouldInstrumentFunction - Return true if the current function should be
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index b610d6810c612..82266ee9f2448 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -6888,42 +6888,6 @@ static void SetNestedNameSpecifier(Sema &S,
DeclaratorDecl *DD, Declarator &D) {
DD->setQualifierInfo(SS.getWithLocInContext(S.Context));
}
-void Sema::deduceHLSLAddressSpace(VarDecl *Decl) {
- // The variable already has an address space (groupshared for ex).
- if (Decl->getType().hasAddressSpace())
- return;
-
- if (Decl->getType()->isDependentType())
- return;
-
- QualType Type = Decl->getType();
- if (Type->isSamplerT() || Type->isVoidType())
- return;
-
- // Template instantiations can lack definition. In such case,
- // we cannot deduce the AS.
- // FIXME: figure out why RWBuffer<float> yields such declaration.
- if (const RecordType *RT =
- dyn_cast<RecordType>(Type->getUnqualifiedDesugaredType())) {
- CXXRecordDecl *RD = Type->getAsCXXRecordDecl();
- if (RD && !RD->isCompleteDefinition())
- return;
- }
-
- // Resource handles.
- if (Type->isHLSLIntangibleType())
- return;
-
- // Only static globals belong to the Private address space.
- // Non-static globals belongs to the cbuffer.
- if (Decl->getStorageClass() != SC_Static && !Decl->isStaticDataMember())
- return;
-
- LangAS ImplAS = LangAS::hlsl_private;
- Type = Context.getAddrSpaceQualType(Type, ImplAS);
- Decl->setType(Type);
-}
-
void Sema::deduceOpenCLAddressSpace(ValueDecl *Decl) {
if (Decl->getType().hasAddressSpace())
return;
@@ -8011,10 +7975,8 @@ NamedDecl *Sema::ActOnVariableDeclarator(
// Handle attributes prior to checking for duplicates in MergeVarDecl
ProcessDeclAttributes(S, NewVD, D);
- if (getLangOpts().HLSL) {
+ if (getLangOpts().HLSL)
HLSL().ActOnVariableDeclarator(NewVD);
- deduceHLSLAddressSpace(NewVD);
- }
if (getLangOpts().OpenACC)
OpenACC().ActOnVariableDeclarator(NewVD);
@@ -13171,7 +13133,7 @@ bool Sema::DeduceVariableDeclarationType(VarDecl
*VDecl, bool DirectInit,
deduceOpenCLAddressSpace(VDecl);
if (getLangOpts().HLSL)
- deduceHLSLAddressSpace(VDecl);
+ HLSL().deduceAddressSpace(VDecl);
// If this is a redeclaration, check that the type we just deduced matches
// the previously declared type.
diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp
index fe600386e6fa9..ca08132ea400b 100644
--- a/clang/lib/Sema/SemaHLSL.cpp
+++ b/clang/lib/Sema/SemaHLSL.cpp
@@ -3138,6 +3138,43 @@ static bool IsDefaultBufferConstantDecl(VarDecl *VD) {
!isInvalidConstantBufferLeafElementType(QT.getTypePtr());
}
+void SemaHLSL::deduceAddressSpace(VarDecl *Decl) {
+ // The variable already has an address space (groupshared for ex).
+ if (Decl->getType().hasAddressSpace())
+ return;
+
+ if (Decl->getType()->isDependentType())
+ return;
+
+ QualType Type = Decl->getType();
+ if (Type->isSamplerT() || Type->isVoidType())
+ return;
+
+ // Template instantiations can lack definition. In such case,
+ // we cannot deduce the AS.
+ // FIXME: figure out why RWBuffer<float> yields such declaration.
+ if (const RecordType *RT =
+ dyn_cast<RecordType>(Type->getUnqualifiedDesugaredType())) {
+ CXXRecordDecl *RD = Type->getAsCXXRecordDecl();
+ if (RD && !RD->isCompleteDefinition())
+ return;
+ }
+
+ // Resource handles.
+ if (isResourceRecordTypeOrArrayOf(Type->getUnqualifiedDesugaredType()))
+ return;
+
+ // Only static globals belong to the Private address space.
+ // Non-static globals belongs to the cbuffer.
+ if (Decl->getStorageClass() != SC_Static && !Decl->isStaticDataMember())
+ return;
+
+ LangAS ImplAS = LangAS::hlsl_private;
+ Type = SemaRef.getASTContext().getAddrSpaceQualType(Type, ImplAS);
+ Decl->setType(Type);
+}
+
+
void SemaHLSL::ActOnVariableDeclarator(VarDecl *VD) {
if (VD->hasGlobalStorage()) {
// make sure the declaration has a complete type
@@ -3146,6 +3183,7 @@ void SemaHLSL::ActOnVariableDeclarator(VarDecl *VD) {
SemaRef.getASTContext().getBaseElementType(VD->getType()),
diag::err_typecheck_decl_incomplete_type)) {
VD->setInvalidDecl();
+ deduceAddressSpace(VD);
return;
}
@@ -3177,6 +3215,8 @@ void SemaHLSL::ActOnVariableDeclarator(VarDecl *VD) {
// process explicit bindings
processExplicitBindingsOnDecl(VD);
}
+
+ deduceAddressSpace(VD);
}
// Walks though the global variable declaration, collects all resource binding
diff --git a/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
b/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
index 602234973c312..7b26dba0d1901 100644
--- a/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
+++ b/clang/test/CodeGenHLSL/GlobalConstructors.hlsl
@@ -1,5 +1,4 @@
-// RUN: %clang_cc1 -triple spirv-unknown-vulkan1.3-compute -x hlsl -emit-llvm
-disable-llvm-passes %s -o - | FileCheck %s --check-prefixes=CHECK,SPIRV
-// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -emit-llvm
-disable-llvm-passes %s -o - | FileCheck %s --check-prefixes=CHECK,DXIL
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -emit-llvm
-disable-llvm-passes %s -o - | FileCheck %s
RWBuffer<float> Buffer;
@@ -11,13 +10,7 @@ void main(unsigned GI : SV_GroupIndex) {}
// CHECK-NOT:@llvm.global_dtors
//CHECK: define void @main()
//CHECK-NEXT: entry:
-
-//SPIRV-NEXT: %0 = call token @llvm.experimental.convergence.entry()
-//SPIRV-NEXT: call spir_func void @_GLOBAL__sub_I_GlobalConstructors.hlsl()
[ "convergencectrl"(token %0) ]
-//SPIRV-NEXT: %1 = call i32 @llvm.spv.flattened.thread.id.in.group()
-//SPIRV-NEXT: call spir_func void @_Z4mainj(i32 %1) [
"convergencectrl"(token %0) ]
-
-//DXIL-NEXT: call void @_GLOBAL__sub_I_GlobalConstructors.hlsl()
-//DXIL-NEXT: %0 = call i32 @llvm.dx.flattened.thread.id.in.group()
-//DXIL-NEXT: call void @_Z4mainj(i32 %0)
+//CHECK-NEXT: call void @_GLOBAL__sub_I_GlobalConstructors.hlsl()
+//CHECK-NEXT: %0 = call i32 @llvm.dx.flattened.thread.id.in.group()
+//CHECK-NEXT: call void @_Z4mainj(i32 %0)
//CHECK-NEXT: ret void
diff --git a/clang/test/CodeGenHLSL/GlobalDestructors.hlsl
b/clang/test/CodeGenHLSL/GlobalDestructors.hlsl
index 9f90971bafd05..9d8c2e65a9598 100644
--- a/clang/test/CodeGenHLSL/GlobalDestructors.hlsl
+++ b/clang/test/CodeGenHLSL/GlobalDestructors.hlsl
@@ -87,7 +87,7 @@ void main(unsigned GI : SV_GroupIndex) {
// NOINLINE-SPIRV: define internal spir_func void @_GLOBAL__D_a()
[[IntAttr:\#[0-9]+]]
// NOINLINE-SPIRV-NEXT: entry:
// NOINLINE-SPIRV-NEXT: %0 = call token
@llvm.experimental.convergence.entry()
-// NOINLINE-SPIRV-NEXT: call spir_func void @_ZN4TailD1Ev(ptr @_ZZ3WagvE1T)
[ "convergencectrl"(token %0) ]
+// NOINLINE-SPIRV-NEXT: call spir_func void @_ZN4TailD1Ev(ptr addrspacecast
(ptr addrspace(10) @_ZZ3WagvE1T to ptr)) [ "convergencectrl"(token %0) ]
// NOINLINE-SPIRV-NEXT: call spir_func void @_ZN6PupperD1Ev(ptr @GlobalPup)
[ "convergencectrl"(token %0) ]
// NOINLINE-SPIRV-NEXT: ret void
From 4521dc1ac4bc63def5cf9d2c46c3b6990cd23131 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= <brio...@google.com>
Date: Wed, 9 Apr 2025 17:23:29 +0200
Subject: [PATCH 5/6] clang-format
---
clang/lib/Sema/SemaHLSL.cpp | 1 -
1 file changed, 1 deletion(-)
diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp
index ca08132ea400b..58f85f7183e1e 100644
--- a/clang/lib/Sema/SemaHLSL.cpp
+++ b/clang/lib/Sema/SemaHLSL.cpp
@@ -3174,7 +3174,6 @@ void SemaHLSL::deduceAddressSpace(VarDecl *Decl) {
Decl->setType(Type);
}
-
void SemaHLSL::ActOnVariableDeclarator(VarDecl *VD) {
if (VD->hasGlobalStorage()) {
// make sure the declaration has a complete type
From 16f8e01a9e30bdce1a486793e4777ab0a8a82d44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nathan=20Gau=C3=ABr?= <brio...@google.com>
Date: Wed, 9 Apr 2025 17:37:07 +0200
Subject: [PATCH 6/6] pr-feedback
---
clang/lib/Sema/SemaHLSL.cpp | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp
index 58f85f7183e1e..0b442b75d174d 100644
--- a/clang/lib/Sema/SemaHLSL.cpp
+++ b/clang/lib/Sema/SemaHLSL.cpp
@@ -3150,16 +3150,6 @@ void SemaHLSL::deduceAddressSpace(VarDecl *Decl) {
if (Type->isSamplerT() || Type->isVoidType())
return;
- // Template instantiations can lack definition. In such case,
- // we cannot deduce the AS.
- // FIXME: figure out why RWBuffer<float> yields such declaration.
- if (const RecordType *RT =
- dyn_cast<RecordType>(Type->getUnqualifiedDesugaredType())) {
- CXXRecordDecl *RD = Type->getAsCXXRecordDecl();
- if (RD && !RD->isCompleteDefinition())
- return;
- }
-
// Resource handles.
if (isResourceRecordTypeOrArrayOf(Type->getUnqualifiedDesugaredType()))
return;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
