erichkeane wrote: > > 2- This patch adds the infrastructure/calls to do the > > OpenACCDialect->LLVM-IR lowering. Unfortunately only a handful of > > constructs are actually functional in the OpenACC dialect, of which data is > > one (hence the choice to do it here, and why I chose to do it as one > > patch). SO, like the Flang OpenACC implementation, attempts to lower below > > CIR/OpenACC Dialect will likely fail. > > This translation was done way back when we started with the OpenACC dialect > and it is likely not what will be supported in the long term for OpenACC > codegen. The idea behind OpenACC code generation was to be done in MLIR until > the LLVM IR dialect and not directly emit LLVM IR as it is done for OpenMP. > SO I'm not sure it is needed to test it with your current lowering.
That is good feedback, thanks! I've modified the patch to remove the lowering, plus modified the commit title and message. https://github.com/llvm/llvm-project/pull/135038 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
