Mateusz =?utf-8?q?Mikuła?= <o...@mateuszmikula.dev>, Mateusz =?utf-8?q?Mikuła?= <o...@mateuszmikula.dev>, Mateusz =?utf-8?q?Mikuła?= <o...@mateuszmikula.dev>, Mateusz =?utf-8?q?Mikuła?= <o...@mateuszmikula.dev> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/134...@github.com>
https://github.com/efriedma-quic commented: Please split this into multiple pull requests; some of these probably need different reviewers, and GitHub doesn't provide any interface for reviewing multiple commits on separately. We want regression tests for the changes for cygwin targets. (We should already have mingw regression tests for most of this stuff; you should be able to just add a RUN line with a cygwin triple.) Suggested split for PRs: - Changes required to build LLVM/clang on a cygwin host using gcc. - Clang driver changes. - The TLSSupported change. - The C++ ABI changes. https://github.com/llvm/llvm-project/pull/134458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
