flovent wrote:

@steakhal Thank you for review! I forgot to mention that the testcases added is 
copied from their non-range verison since they have same effect to iterator 
which mentioned in PR description, the only change is the method's name and a 
parameter named `vec` in test function to simulate `range`.

so the `Design decision` part is completely copied from original testcase.

but it does seems that the problem you mentioned is suspicious, i will take a 
look on them and see what happens after i change it(like add commented  lines 
back).

https://github.com/llvm/llvm-project/pull/129719
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to