llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clangd Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/133589.diff 4 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp (+4-7) - (modified) clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp (+1-3) - (modified) clang-tools-extra/clangd/ConfigCompile.cpp (+1-2) - (modified) clang-tools-extra/clangd/index/dex/Dex.cpp (+1-2) ``````````diff diff --git a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp index 902490f4d33c1..27045816a80d3 100644 --- a/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp @@ -333,13 +333,10 @@ SignalHandlerCheck::SignalHandlerCheck(StringRef Name, : ClangTidyCheck(Name, Context), AsyncSafeFunctionSet(Options.get("AsyncSafeFunctionSet", AsyncSafeFunctionSetKind::POSIX)) { - if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal) { - for (StringRef v : MinimalConformingFunctions) - ConformingFunctions.insert(v); - } else { - for (StringRef v : POSIXConformingFunctions) - ConformingFunctions.insert(v); - } + if (AsyncSafeFunctionSet == AsyncSafeFunctionSetKind::Minimal) + ConformingFunctions.insert_range(MinimalConformingFunctions); + else + ConformingFunctions.insert_range(POSIXConformingFunctions); } void SignalHandlerCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { diff --git a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp index c41f81b0f0b58..a60a4faa32a16 100644 --- a/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp @@ -343,9 +343,7 @@ void InconsistentDeclarationParameterNameCheck::check( void InconsistentDeclarationParameterNameCheck::markRedeclarationsAsVisited( const FunctionDecl *OriginalDeclaration) { - for (const FunctionDecl *Redecl : OriginalDeclaration->redecls()) { - VisitedDeclarations.insert(Redecl); - } + VisitedDeclarations.insert_range(OriginalDeclaration->redecls()); } } // namespace clang::tidy::readability diff --git a/clang-tools-extra/clangd/ConfigCompile.cpp b/clang-tools-extra/clangd/ConfigCompile.cpp index 21304a8c0fac7..3d7f792aa136b 100644 --- a/clang-tools-extra/clangd/ConfigCompile.cpp +++ b/clang-tools-extra/clangd/ConfigCompile.cpp @@ -439,8 +439,7 @@ struct FragmentCompiler { [Normalized(std::move(Normalized))](const Params &, Config &C) { if (C.Diagnostics.SuppressAll) return; - for (llvm::StringRef N : Normalized) - C.Diagnostics.Suppress.insert(N); + C.Diagnostics.Suppress.insert_range(Normalized); }); if (F.UnusedIncludes) { diff --git a/clang-tools-extra/clangd/index/dex/Dex.cpp b/clang-tools-extra/clangd/index/dex/Dex.cpp index 5643ba0c5e4ce..575a96a112979 100644 --- a/clang-tools-extra/clangd/index/dex/Dex.cpp +++ b/clang-tools-extra/clangd/index/dex/Dex.cpp @@ -181,8 +181,7 @@ std::unique_ptr<Iterator> Dex::createFileProximityIterator( Sources[Path] = SourceParams(); auto PathURI = URI::create(Path).toString(); const auto PathProximityURIs = generateProximityURIs(PathURI.c_str()); - for (const auto &ProximityURI : PathProximityURIs) - ParentURIs.insert(ProximityURI); + ParentURIs.insert_range(PathProximityURIs); } // Use SymbolRelevanceSignals for symbol relevance evaluation: use defaults // for all parameters except for Proximity Path distance signal. `````````` </details> https://github.com/llvm/llvm-project/pull/133589 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
