https://github.com/bcardosolopes commented:

I have only minor inline comments, good direction.

The PR is a bit big but I can see this requires touching everywhere in CIRGen 
and also LLVM lowering support, which is good end-to-end testing.

If there are things there are not needed right now, it'd be better to remove it 
for extra clarity. Have you checked that?

https://github.com/llvm/llvm-project/pull/132974
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to