================
@@ -6418,6 +6418,12 @@ def warn_signed_bitfield_enum_conversion : Warning<
   InGroup<BitFieldEnumConversion>, DefaultIgnore;
 def note_change_bitfield_sign : Note<
   "consider making the bitfield type %select{unsigned|signed}0">;
+def warn_ms_bitfield_mismatched_storage_packing : Warning<
+  "bit-field %0 of type %1 has a different storage size (%2 vs %3 bytes) than 
the "
+  "preceding bit-field and may not be packed under MSVC ABI">,
+  InGroup<MSBitfieldCompatibility>, DefaultIgnore;
----------------
ojhunt wrote:

ah good point, I'll update msvc references (there are others in the docs) to 
say windows platform abi.

I don't believe this should be an on by default warning at all - it's a warning 
specifically about difference in packing/padding on a platform you aren't 
targeting. In the overwhelming majority of cases that is not something that 
matters. For folk actually targeting the windows abi, the existing warnings 
will fire (because the sad packing/padding would actually occur).

https://github.com/llvm/llvm-project/pull/117428
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to