NoQ added a comment.

This defensive check looks reasonable regardless of how well we model unions 
(we don't). Thanks for the patch!



================
Comment at: lib/StaticAnalyzer/Core/CallEvent.cpp:706
+      }
       Values.push_back(IvarLVal);
       return;
----------------
I believe there's not much to `push_back` here when we don't have the region. 
So this can go under the `if(){}` as well.


Repository:
  rL LLVM

https://reviews.llvm.org/D31840



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D31840: [an... Alexander Shaposhnikov via Phabricator via cfe-commits
    • [PATCH] D31840... Artem Dergachev via Phabricator via cfe-commits
    • [PATCH] D31840... Alexander Shaposhnikov via Phabricator via cfe-commits
    • [PATCH] D31840... Artem Dergachev via Phabricator via cfe-commits

Reply via email to