================
@@ -2473,11 +2473,9 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned 
BuiltinID, CallExpr *TheCall) {
     break;
   }
   case Builtin::BI__builtin_hlsl_dot2add: {
-    // Check number of arguments should be 3
     if (SemaRef.checkArgCount(TheCall, 3))
       return true;
 
-    // Check first two arguments are vector of length 2 with half data type
     auto checkHalfVectorOfSize2 = [](clang::QualType PassedType) -> bool {
----------------
sumitsays wrote:

Makes sense. I am thinking on it a bit stretched: Now we don't need to do any 
semantics check (just need to set the type) because we are explicitly 
specifying the exact overload.
Isn't it? 

https://github.com/llvm/llvm-project/pull/131237
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to