https://github.com/steakhal requested changes to this pull request.
I've only spotchecked. It looks correct at first glance. I somewhat dislike that practically every file needs to include CFG.h; I'd advise revisiting this. Do you intentionally take `CFGBlock::ConstCFGElementRef` as a const parameter? That doesn't seem to do anything. I'd rather not spell `const` unless there is a compelling reason to do so. Then the final question, why is `ConstCFGElementRef` nested under the `CFGBlock`? It makes it spell every time, leading to noise. I'd revisit this, and possibly change its implementation to allow less mouthful spelling of this type. https://github.com/llvm/llvm-project/pull/128251 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
