YutongZhuu wrote: > I can't for the life of me see a good way to use this. The `if(p)` pattern > is so common that no code base could ever turn on this warning. We could > PERHAPS check that we're in the process of checking a condition expression > and suppress this diagnostic, or recognize this pattern somehow, but without > some more work to make this more useful, I don't think we can accept this > diagnostic.
Hi, I submitted this PR because of the implementation was easy and I wanted to know your opinions. Let me know if I should put more work into this issue. If the answer is No, I am okay with closing this MR, and we should also close all relevant issues. https://github.com/llvm/llvm-project/pull/131523 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits