beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land.
One minor nitpick on the test case, but otherwise this looks fine to me. ================ Comment at: test/Driver/immediate-options.c:19 +// RUN: %clang -print-resource-dir | FileCheck %s -check-prefix=PRINT-RESOURCE-DIR +// PRINT-RESOURCE-DIR: {{.*}} + ---------------- This should probably be matching `+` instead of `*`. As written this would succeed even if the output was empty. https://reviews.llvm.org/D31447 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits