================
@@ -597,6 +597,9 @@ llvm::Error Interpreter::CreateExecutor() {
     auto JTMB = createJITTargetMachineBuilder(TT);
     if (!JTMB)
       return JTMB.takeError();
+#if defined(_WIN32)
----------------
mstorsjo wrote:

I'm not sure what the common practice is for the JIT/interpreter side, but I 
would prefer to use a check in code, whether the target triple is windows, 
rather than using an ifdef. Most of clang is cross-compiling agnostic anyway. 
For the JIT that's obviously not the case, but by not using ifdefs, you get the 
code compile tested in all builds, not only the windows ones.

https://github.com/llvm/llvm-project/pull/127468
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to