PhilippRados wrote:

I applied the mentioned changes from above and merged the two diagnostics into 
a single one. I also added the field IsInsideCondition to the `Expr` class and 
everything works. However I’m not sure whether or not this single diagnostic 
warrants the extra field in the class.

I also saw that enum/boolean fields in `Expr` are represented using the 
`ExprBits` bitfield so if this were a valid approach then adding it to the 
bitfield would probably be more space efficient.

https://github.com/llvm/llvm-project/pull/115234
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to