aaron.ballman added a comment.

I'm not certain of a good way to test it, but I have a question about the value 
you picked for `init_priority`. My understanding of the values starting from 
101 is that 1-100 are reserved for implementation use. Is that understanding 
correct? If so, you may want to pick a value below 100 to ensure there's not an 
arms race with the user. I believe this may require some alteration to 
SemaDeclAttr.cpp to not diagnose when this is coming from a system header. 
Otherwise, what's to stop the user from having something marked 
`constructor(101)` that attempts to use a stream, but can't because they're not 
initialized yet?


https://reviews.llvm.org/D31413



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to