https://github.com/HerrCai0907 requested changes to this pull request.
The idea of check is good. But I think the matcher need to refactor a lot. 1. Please place value check in ast matcher part, match all integer will cost lots of cpu and ram to store temporary results. 2. Maybe consider to write 2 different matcher, one for positive (include e.g. +255 and 255), the other for negative (-128) since they have different value scopes. https://github.com/llvm/llvm-project/pull/127430 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
