https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/127165
None >From 13dc860f8c35928fa251825f80adba87600c2b07 Mon Sep 17 00:00:00 2001 From: Kazu Hirata <k...@google.com> Date: Thu, 13 Feb 2025 09:45:09 -0800 Subject: [PATCH] [clang-reorder-fields] Avoid repeated hash lookups (NFC) --- .../clang-reorder-fields/ReorderFieldsAction.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp b/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp index aeb7fe90f2175..ea0207619fb2b 100644 --- a/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp +++ b/clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp @@ -70,11 +70,12 @@ getNewFieldsOrder(const RecordDecl *Definition, } SmallVector<unsigned, 4> NewFieldsOrder; for (const auto &Name : DesiredFieldsOrder) { - if (!NameToIndex.count(Name)) { + auto It = NameToIndex.find(Name); + if (It == NameToIndex.end()) { llvm::errs() << "Field " << Name << " not found in definition.\n"; return {}; } - NewFieldsOrder.push_back(NameToIndex[Name]); + NewFieldsOrder.push_back(It->second); } assert(NewFieldsOrder.size() == NameToIndex.size()); return NewFieldsOrder; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits