https://github.com/jhuber6 requested changes to this pull request.

My preference is that we do not introduce new flags, but use the ones we have 
already and use `-Xarch` as the canonical way to do it.
```
-fsanitize_instr_generate // Both host and all devices
-Xarch_host -fsanitize_instr_generate // Only on the host
-Xarch_device -fsanitize_instr_generate // Only on the devices
-Xarch_nvptx64 -fsanitize_instr_generate  // Only on NVPTX targets
-Xarch_gfx90a -fsanitize_instr_generate  // Only on gfx90a
```
All of this handling should be done for you by the `getArgsForToolchain()` 
interface that's called before we generate the arguments from the tools. So, 
all this should require is tests + documentation for this usage. You should 
just be able to replace existing checks on these new flags to the standard ones.

https://github.com/llvm/llvm-project/pull/94268
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to