rnk added inline comments.
================ Comment at: lib/Basic/XRayFunctionFilter.cpp:21 + : AlwaysInstrument( + llvm::SpecialCaseList::createOrDie(AlwaysInstrumentPaths)), + NeverInstrument(llvm::SpecialCaseList::createOrDie(NeverInstrumentPaths)), ---------------- Hm, phab ate my comment about this. I don't think we should use this API in clang. Instead, we should use the `::create(...)` version and issue a diagnostic similar to err_drv_malformed_sanitizer_blacklist from the caller of this function. https://reviews.llvm.org/D30388 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
