Author: Donát Nagy Date: 2025-02-10T13:25:07+01:00 New Revision: 729416e586fba71b4f63d71b1b5c765aefbf200b
URL: https://github.com/llvm/llvm-project/commit/729416e586fba71b4f63d71b1b5c765aefbf200b DIFF: https://github.com/llvm/llvm-project/commit/729416e586fba71b4f63d71b1b5c765aefbf200b.diff LOG: [analyzer][NFC] Remove "V2" from ArrayBoundCheckerV2.cpp (#126094) Previously commit 6e17ed9b04e5523cc910bf171c3122dcc64b86db deleted the obsolete checker `alpha.security.ArrayBound` which was implemented in `ArrayBoundChecker.cpp` and renamed the checker `alpha.security.ArrayBoundV2` to `security.ArrayBound`. This commit concludes that consolidation by renaming the source file `ArrayBoundCheckerV2.cpp` to `ArrayBoundChecker.cpp` (which was "freed up" by the previous commit). Added: clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp Modified: clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn Removed: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp ################################################################################ diff --git a/clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp b/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp similarity index 98% rename from clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp rename to clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp index 6f8d6dbd573f403..109faacf1726ab4 100644 --- a/clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/ArrayBoundChecker.cpp @@ -1,4 +1,4 @@ -//== ArrayBoundCheckerV2.cpp ------------------------------------*- C++ -*--==// +//== ArrayBoundChecker.cpp -------------------------------------------------==// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. @@ -11,12 +11,6 @@ // //===----------------------------------------------------------------------===// -// NOTE: The name of this file ends with "V2" because previously -// "ArrayBoundChecker.cpp" contained the implementation of another (older and -// simpler) checker that was called `alpha.security.ArrayBound`. -// TODO: Rename this file to "ArrayBoundChecker.cpp" when it won't be confused -// with that older file. - #include "clang/AST/CharUnits.h" #include "clang/AST/ParentMapContext.h" #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" @@ -297,7 +291,8 @@ static std::pair<ProgramStateRef, ProgramStateRef> compareValueToThreshold(ProgramStateRef State, NonLoc Value, NonLoc Threshold, SValBuilder &SVB, bool CheckEquality = false) { if (auto ConcreteThreshold = Threshold.getAs<nonloc::ConcreteInt>()) { - std::tie(Value, Threshold) = getSimplifiedOffsets(Value, *ConcreteThreshold, SVB); + std::tie(Value, Threshold) = + getSimplifiedOffsets(Value, *ConcreteThreshold, SVB); } // We want to perform a _mathematical_ comparison between the numbers `Value` diff --git a/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt b/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt index ccff5d0ac3b9649..591004344098781 100644 --- a/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt +++ b/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt @@ -7,7 +7,7 @@ set(LLVM_LINK_COMPONENTS add_clang_library(clangStaticAnalyzerCheckers AnalysisOrderChecker.cpp AnalyzerStatsChecker.cpp - ArrayBoundCheckerV2.cpp + ArrayBoundChecker.cpp BasicObjCFoundationChecks.cpp BitwiseShiftChecker.cpp BlockInCriticalSectionChecker.cpp diff --git a/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn b/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn index c1bba99be3ba5c3..d9c32575366399b 100644 --- a/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn +++ b/llvm/utils/gn/secondary/clang/lib/StaticAnalyzer/Checkers/BUILD.gn @@ -16,7 +16,7 @@ static_library("Checkers") { sources = [ "AnalysisOrderChecker.cpp", "AnalyzerStatsChecker.cpp", - "ArrayBoundCheckerV2.cpp", + "ArrayBoundChecker.cpp", "BasicObjCFoundationChecks.cpp", "BitwiseShiftChecker.cpp", "BlockInCriticalSectionChecker.cpp", _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
