djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.

Looks good, just minor remarks.



================
Comment at: include/clang/Format/Format.h:974
+  ///    # With:
+  ///    MacroBlockBegin: "^\
+  ///    NS_MAP_BEGIN|\
----------------
I'd contract these to a single line.


================
Comment at: include/clang/Format/Format.h:1007
+  ///    int f() {                              int f() {
+  ///    int = 1;                                   int i = 1;
+  ///                                               i = foo();
----------------
nit: The indent on the right is incorrect (i.e. should not be different).


https://reviews.llvm.org/D30990



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to