https://github.com/shafik commented:

Definitely makes sense. Definitely we need a test, I think the right test to 
add an example to is `ast-dump-decl.cpp`.

Could you also put a few more details in the summary, basically explain you are 
modifying `TextNodeDumper::VisitEnumDecl` to be more consistent ...

It would be better to spell out `TextNodeDumper::VisitFunctionDecl` and 
`TextNodeDumper::VisitCXXRecordDecl` as well.

https://github.com/llvm/llvm-project/pull/124409
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to