https://github.com/cor3ntin commented:
The code and test coverage looks good. There are a couple of comments that have not been addressed. And there is @zygoloid suggestion to generalize `SubstNonTypeTemplateParmPackExpr`. Maybe trying to land that today is not the brightest idea. However, we should target to have it landed before rc2 or something like that (we'd make a lot of folks happy having that in 20, I think) @erichkeane @AaronBallman @Sirraide https://github.com/llvm/llvm-project/pull/121417 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
