jvoung wrote: > > I'm not really that opposed to this solution, but the other solutions sound > > better to me, though with their own caveats (time, work, GTest macros are > > only for GTest). I'm fine with this, if all other options are not feasible > > to implement in the near to mid term, but a second non-blocking review from > > another clang-tidy dev would be best.
Just coming back to this, would you mind clarifying "but a second non-blocking review from another clang-tidy dev would be best"? Does ymand and Xazax-hun count? https://github.com/llvm/llvm-project/pull/115051 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
