================ @@ -20287,7 +20287,11 @@ void Sema::DiagnoseEqualityWithExtraParens(ParenExpr *ParenE) { ExprResult Sema::CheckBooleanCondition(SourceLocation Loc, Expr *E, bool IsConstexpr) { - DiagnoseAssignmentAsCondition(E); + // This warning is already covered by `warn_assignment_bool_context` in C++. + // NOTE: Ideally both warnings would be combined + if (!getLangOpts().CPlusPlus || getLangOpts().ObjC) ---------------- erichkeane wrote:
Is this right? Won't this cause double-diagnostic in ObjC++? https://github.com/llvm/llvm-project/pull/115234 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits