================
@@ -1448,3 +1448,18 @@ def FeatureTaggedGlobals : 
SubtargetFeature<"tagged-globals",
     "AllowTaggedGlobals",
     "true", "Use an instruction sequence for taking the address of a global "
     "that allows a memory tag in the upper address bits">;
+
+def FeatureVendorMIPSCMove : SubtargetFeature<"xmipscmove", 
"HasVendorMIPSCMove",
+                                       "true", "Using CCMov",
+                                       [Feature64Bit]>;
----------------
djtodoro wrote:

>It would be better if this and def FeatureVendorMIPSLoadStorePairs both used 
>RISCVExtension. I think this means some changes to the functions on 
>riscvsubtarget too, it should be clear to follow from the other vendor 
>extensions. This will also have a knock-on effect on some other tests, 
>especially relating to RISCVISAInfo (and also some in clang iirc), but this is 
>for the better - it means the compiler can show it supports your extensions 😄

Good point. Yes, I have added it, and resolved test failures (there is one unit 
test as well). Thanks :)

>Please may you also put these definitions beside the other vendor extensions, 
>rather than at the end with these codegen options? The section starts 
>somewhere around line 1020, and you'll see each vendor's extensions are with 
>each other.

Sure.

https://github.com/llvm/llvm-project/pull/121394
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to