Author: Hubert Tong Date: 2025-01-15T17:44:25-04:00 New Revision: 1c3df5308a86aaed4c91869982d365cc20f2b511
URL: https://github.com/llvm/llvm-project/commit/1c3df5308a86aaed4c91869982d365cc20f2b511 DIFF: https://github.com/llvm/llvm-project/commit/1c3df5308a86aaed4c91869982d365cc20f2b511.diff LOG: [NFC] Explicitly use `clang::Module` in test file https://github.com/llvm/llvm-project/pull/122887 uses `Module` to refer to `clang::Module` in a test that has `using namespace llvm;`. This causes lookup ambiguity with `llvm::Module` if the headers involved expose that name (e.g., for downstream codebases). Added: Modified: clang/unittests/AST/ExternalASTSourceTest.cpp Removed: ################################################################################ diff --git a/clang/unittests/AST/ExternalASTSourceTest.cpp b/clang/unittests/AST/ExternalASTSourceTest.cpp index ad209604971f43..b42a3be05e9bb1 100644 --- a/clang/unittests/AST/ExternalASTSourceTest.cpp +++ b/clang/unittests/AST/ExternalASTSourceTest.cpp @@ -69,7 +69,7 @@ TEST(ExternalASTSourceTest, FailedLookupOccursOnce) { bool FindExternalVisibleDeclsByName(const DeclContext *, DeclarationName Name, - Module *NamedModule) override { + clang::Module *NamedModule) override { if (Name.getAsString() == "j") ++Calls; return false; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits