Author: Kazu Hirata Date: 2025-01-13T11:38:20-08:00 New Revision: 19c0a6b5eb3a0c0619fccc140740500737fdcd47
URL: https://github.com/llvm/llvm-project/commit/19c0a6b5eb3a0c0619fccc140740500737fdcd47 DIFF: https://github.com/llvm/llvm-project/commit/19c0a6b5eb3a0c0619fccc140740500737fdcd47.diff LOG: [Analysis] Migrate away from PointerUnion::dyn_cast (NFC) (#122652) Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with // isa<T>, cast<T> and the llvm::dyn_cast<T> Literal migration would result in dyn_cast_if_present (see the definition of PointerUnion::dyn_cast), but this patch uses dyn_cast because we expect Ctx->FunArgs to be nonnull. Added: Modified: clang/lib/Analysis/ThreadSafetyCommon.cpp Removed: ################################################################################ diff --git a/clang/lib/Analysis/ThreadSafetyCommon.cpp b/clang/lib/Analysis/ThreadSafetyCommon.cpp index 050daee1168d4b..13cd7e26dc16f3 100644 --- a/clang/lib/Analysis/ThreadSafetyCommon.cpp +++ b/clang/lib/Analysis/ThreadSafetyCommon.cpp @@ -336,7 +336,7 @@ til::SExpr *SExprBuilder::translateDeclRefExpr(const DeclRefExpr *DRE, : (cast<ObjCMethodDecl>(D)->getCanonicalDecl() == Canonical)) { // Substitute call arguments for references to function parameters if (const Expr *const *FunArgs = - Ctx->FunArgs.dyn_cast<const Expr *const *>()) { + dyn_cast<const Expr *const *>(Ctx->FunArgs)) { assert(I < Ctx->NumArgs); return translate(FunArgs[I], Ctx->Prev); } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits