manmanren added a comment.
Please update the patch with context:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Thanks,
Manman
================
Comment at: unittests/Basic/SourceManagerTest.cpp:251
std::string Name;
- bool isDefinition; // if false, it is expansion.
-
- MacroAction(SourceLocation Loc, StringRef Name, bool isDefinition)
- : Loc(Loc), Name(Name), isDefinition(isDefinition) { }
+ int Kind; // 0 expansion, 1 definition, 2 undefinition
+
----------------
Can we make this an enum?
https://reviews.llvm.org/D29923
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
