https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/122651
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect Ptr to be nonnull.
>From 9427f6765355636976ee0b67a0710e74d7312df5 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Sun, 12 Jan 2025 14:02:28 -0800
Subject: [PATCH] [AST] Migrate away from PointerUnion::dyn_cast (NFC)
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
// isa<T>, cast<T> and the llvm::dyn_cast<T>
Literal migration would result in dyn_cast_if_present (see the
definition of PointerUnion::dyn_cast), but this patch uses dyn_cast
because we expect Ptr to be nonnull.
---
clang/include/clang/AST/DeclBase.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang/include/clang/AST/DeclBase.h
b/clang/include/clang/AST/DeclBase.h
index 82932e098c86f0..77abd8b657a616 100644
--- a/clang/include/clang/AST/DeclBase.h
+++ b/clang/include/clang/AST/DeclBase.h
@@ -1334,7 +1334,7 @@ class DeclListNode {
reference operator*() const {
assert(Ptr && "dereferencing end() iterator");
- if (DeclListNode *CurNode = Ptr.dyn_cast<DeclListNode*>())
+ if (DeclListNode *CurNode = dyn_cast<DeclListNode *>(Ptr))
return CurNode->D;
return cast<NamedDecl *>(Ptr);
}
@@ -1344,7 +1344,7 @@ class DeclListNode {
inline iterator &operator++() { // ++It
assert(!Ptr.isNull() && "Advancing empty iterator");
- if (DeclListNode *CurNode = Ptr.dyn_cast<DeclListNode*>())
+ if (DeclListNode *CurNode = dyn_cast<DeclListNode *>(Ptr))
Ptr = CurNode->Rest;
else
Ptr = nullptr;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
