sammccall added a comment.

Thanks for the comments!



================
Comment at: include-fixer/SymbolIndexManager.cpp:106
       // Match the identifier name without qualifier.
-      if (Symbol.getName() == Names.back()) {
-        bool IsMatched = true;
----------------
hokein wrote:
> Just want to verify: this judgement is not needed as it is guaranteed in Line 
> 96 `DB.get()->search(Names.back())` right?
Yes. The existing non-fuzzy implementations all make this guarantee, and we 
decide that we'll accept results from fuzzy implementations now too.


https://reviews.llvm.org/D30720



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to