Author: Ryosuke Niwa Date: 2024-12-20T10:18:08-08:00 New Revision: 5162fde6ee6565d39511e451c04865e7b53bcdcc
URL: https://github.com/llvm/llvm-project/commit/5162fde6ee6565d39511e451c04865e7b53bcdcc DIFF: https://github.com/llvm/llvm-project/commit/5162fde6ee6565d39511e451c04865e7b53bcdcc.diff LOG: [webkit.UncountedLambdaCapturesChecker] Fix a nullptr deference. (#120702) Added a nullptr check. Added: clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures-find-lambda-crash.cpp Modified: clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp Removed: ################################################################################ diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp index da9698e327562e..a57499d52acd0c 100644 --- a/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedLambdaCapturesChecker.cpp @@ -155,6 +155,8 @@ class UncountedLambdaCapturesChecker if (!Init) return nullptr; TempExpr = dyn_cast<CXXBindTemporaryExpr>(Init->IgnoreParenCasts()); + if (!TempExpr) + return nullptr; return dyn_cast_or_null<LambdaExpr>(TempExpr->getSubExpr()); } diff --git a/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures-find-lambda-crash.cpp b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures-find-lambda-crash.cpp new file mode 100644 index 00000000000000..4d9edb75b7ff36 --- /dev/null +++ b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures-find-lambda-crash.cpp @@ -0,0 +1,16 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=webkit.UncountedLambdaCapturesChecker -verify %s +// expected-no-diagnostics + +struct Foo { + int x; + int y; + Foo(int x, int y) : x(x) , y(y) { } + ~Foo() { } +}; + +Foo bar(const Foo&); +void foo() { + int x = 7; + int y = 5; + bar(Foo(x, y)); +} _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
