mstorsjo wrote: > > > #120370 was reverted, because libc++ tests expose major problem: > > > Tests and likely many users can have `-nostdlib++ -lc++`. > > > The if we remove c++ sanitizer runtimes from linking it will break them > > > and force to add `-fsanitize-link-c++-runtime` > > > > > > That's indeed a problem... However the libc++ test failure, as far as I can > > see, seems to be that there was a libc++ test that used to fail when built > > with sanitizers, but that test now no longer fail in that configuration. > > (I'm not entirely sure why it did use to fail though - but I guess that > > discussion belongs in #120370 - I'll comment more on it there.) > > That's apply to asan,msan > > `-nostdlib++ -lc++` is relevant for many ubsan tests > https://lab.llvm.org/buildbot/#/builders/25/builds/5017
Ah, I see, yeah, there's clearly not just one single test failing there. I mirrored part of this conversation into #120370 where it may be more on topic regarding the fallout of that change. https://github.com/llvm/llvm-project/pull/108357 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
