================
@@ -1,4 +1,5 @@
 set(LLVM_LINK_COMPONENTS
+  Core
----------------
shiltian wrote:

> This shouldn't be necessary. I think this code is in the wrong place, I would 
> expect it to go in lib/CodeGen/Targets, not lib/Basic

And then to have clang depend on LLVM's CodeGen component? If that's the case, 
I don't think that is correct. That is even worse.

> Does this create additional dependencies on clang based tools that don't need 
> to use LLVM IR? For example, clang-format?

That's a good question. I think it does. Do you have suggestions on how to 
design the interface?

https://github.com/llvm/llvm-project/pull/104661
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to